do not hyphenate bare URLs #2513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first thought reading this is _yikes_: regexes and pseudo-HTML. What I'd give for a parsed data structure here, one that could be confidently maintained. Bare URLs do predictably get `class="bare"`, so perhaps this will not break anything else. Tests pass. I'm a bit worried about performance. This _only_ avoids hyphenating bare URLs. Code spans and everything else behave the same as before. For example, `/etc/services` may still become ```text /etc/ser- vices ``` if it is rendered near the end of a line.
meonkeys
force-pushed
the
do-not-hyphenate-bare-URLs
branch
from
1dd713d
to
5e5fa5a
Compare
meonkeys
added a commit
to meonkeys/print-this
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit log message for details, including caveats)
(sorry about the force push, I won't do any more of those)