Switch to sass-embedded #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I highly expect issues on JRuby. |
|
It seems to be installable on JRuby. However, it does require compiling native extensions, so there could be additional system requirements. |
|
The sass-embedded gem supports MRI, JRuby, and TruffleRuby. The "native extension" is a dart runtime binary. For JRuby it use a Rakefile extension to install the correct dart executable for the running platform. The main limitation is the platforms that dart-sdk supports. It should cover the vast majority of users, but there are systems that not supported, for example, BSD is not supported. The following are the currently supported platforms:
|
|
The issue is additionally complicated by the way how things are packaged in asciidoctorj-epub3. Need to think a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to use sass-embedded (dart-sass) to compile scss stylesheets.