Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #281 prevent document from overriding epubcheck/kindlegen path attributes #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slonopotamus
Copy link
Contributor

No description provided.

@slonopotamus
Copy link
Contributor Author

slonopotamus commented Mar 3, 2020

@mojavelinux is there any way how I can do this without sneaking into document internals? The problem is that I want to block document from modifying attribute even if it was not specified on command-line via -a attr=value.

Ignore the fact that tests fail on 1.5.x, I'll just ignore them (pun not intended).

@slonopotamus slonopotamus force-pushed the kindllegen-epubcheck-path-override branch 2 times, most recently from 2c6d22e to 77b64ec Compare March 3, 2020 17:55
@slonopotamus
Copy link
Contributor Author

See asciidoctor/asciidoctor#3587

@slonopotamus slonopotamus force-pushed the kindllegen-epubcheck-path-override branch from 77b64ec to 63fe31d Compare July 2, 2020 07:33
@mojavelinux
Copy link
Member

@mojavelinux is there any way how I can do this without sneaking into document internals?

You can find an example in Asciidoctor PDF. See https://github.com/asciidoctor/asciidoctor-pdf/blob/f880a52c2eb8d62e4e7f11edc54c6b4bae828161/lib/asciidoctor/pdf/converter.rb#L145

It's not a public API, which I agree would be nice. But it's also about timing. The converter needs to be able to set this before the document is allowed to do so.

Another way of doing it is to use a preprocessor extension (which doesn't touch the document reader).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants