New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added octave up and down buttons #409
base: master
Are you sure you want to change the base?
Conversation
1416eb2
to
a376319
Compare
a376319
to
6b672e8
Compare
yeah that is an issue in Surge XT too. I am not sure how to go about fixing it so any ideas you might have would be greatly appreciated. |
Unfortunately, I have no enough experience related to JUCE, so I have really no idea, how to overcome this problem. So, I really would not like to express any negative criticism, but I have also encountered another problem, which is marginal to the current issue but might be related: JUCE does not handle the mapping of PC keyboard layout schemes properly. I use a Hungarian PC keyboard, where the positions of the Z and Y keys are swapped compared to the original US keyboards. Interestingly, my Z key, which is next to T, does not produce any sound - but the Y key does, which is next to X, according to Hungarian keyboard layout. |
@FulopNandor Yes, JUCE virtual keyboard only supports QWERTY layout. For Surge XT I had to write specific layouts and offer an option to switch between them, you can see here: https://github.com/surge-synthesizer/surge/blob/2834ca4c4fb270b1987bc0de1c47b9c0830563e6/src/surge-xt/SurgeSynthEditor.h#L118 And then provide UI for switching between those layouts. |
@mkruselj, thank you for your answer, I am going to study that!:-) |
I added octave shift buttons and very basic documentation for the feature.
This currently has an issue where if press one of the octave buttons while holding notes it can cause them to get stuck. but this is also an issue in Surge-XT and LMMS iirc.
Also at some point I hope to add a panic button that will clear all audio output and active notes.