fix some unused parameters #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-dant
commented
Mar 3, 2023
| @@ -232,16 +232,16 @@ auto static_if(F&& f) -> std::enable_if_t<b> | |||
| std::forward<F>(f)(empty_t{}); | |||
| } | |||
| template <bool b, typename F> | |||
| auto static_if(F&& f) -> std::enable_if_t<!b> | |||
There was a problem hiding this comment.
Maybe these should just be annotated as maybe unused instead of removed
There was a problem hiding this comment.
Sorry for the very late review! This changes the signature of the function so I don't think this work. Maybe you can do it like this:
template <bool b, typename F>
auto static_if(F&&) -> std::enable_if_t<!b>??
|
Sorry for the late review of the code. I'd be happy to merge it once the issues in the comment is addressed and the conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #137
PS Thanks for your work