Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: point to Pulley fork with iOS 14 fixes #4224

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Dec 5, 2020

The type of this PR is: Bugfix

This PR resolves CX-875

Description

The Pulley dependency we use for the city guide UI had some issues on iOS 14 with updating certain properties causing an autolayout loop that would cause the UI to hang here: 52inc/Pulley#390 and this is what is causing city guide not to launch. We are using a fork of the original repo that exposes some properties to Objective-C and addresses some bugs here: https://github.com/l2succes/Pulley. The issues have since been fixed in the original repo. This PR points to a fork that pulls in those changes. Also opened a PR in the fork we are using here: l2succes/Pulley#4, if that gets merged we can point to that fork again.

Screenshots

Before

beforeCity

After

afterCity

Follow-ups

  • Get PR merged into fork we are using and point to the fork again
  • Should we try to get changes in our fork merged to original repo so we can point to original repo and get future bug fixes?
  • Use non-deprecated callbacks for CLLocationManager

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

@brainbicycle brainbicycle marked this pull request as ready for review December 6, 2020 22:55
@MounirDhahri MounirDhahri merged commit 0e25ae6 into master Dec 7, 2020
@MounirDhahri MounirDhahri deleted the brian/city-guide-hang branch December 7, 2020 12:35
@MounirDhahri
Copy link
Member

Thanks for fixing this @brainbicycle 🎉
@ds300 @pvinis I will merge this for now for the QA session later. Please feel free to leave any review comments and we'll fix them later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants