-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata testing #14
Open
mororor
wants to merge
15
commits into
master
Choose a base branch
from
metadataTesting
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Metadata testing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still very buggy. I.e. UI does not work - controller has most of the basic functionality - store works as expected so far
added aingleType property to Schema, added support for single Type property to Controller. UI: Basic editing features
- ./store.js: useMetadata() does not work as expected - cleanup and fruther functionality required
small schema improvements added state to metadata input component
metadata object now owns an values object like: values: { value: { status: 'actual', value: 'value'} where value key equal value string value. status can be: 'actual': as in tripleStore 'delete': delete from tripleStore 'draft': add to tripleStore also added ui option to delete metadata
- started generalization to allow for linking to resources in MetadataEditor - implemented this feature draft-like
code clean up some ui eye-candy some ui key-events
- everything really sketchy and buggy for the purpose some file renaming and code movement. extracted some stuff to ui
Very nice, will properly review tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetadataEditor and MetadataHub:
Basic functionality is complete. Code is in orderly state.