add arrow-core-serialization SerializersModule #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not including Option due to type restriction
allows adding `Option` support to `ArrowModule`
tKe
changed the title
serras
approved these changes
May 12, 2024
|
@tKe would you be able to create PR against |
|
Sure - I'll look to update it tonight/tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack, this PR adds in an
ArrowModuleto simplify including the arrow serializers in aSerializersModule {}definition.I've also lifted the restriction from
OptionSerializeras discussed in that thread, but can roll this back if desired.