Add f16 support for modulus and norm #3258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
force-pushed
the
half_mod
branch
4 times, most recently
from
6e0dec7
to
9c1389e
Compare
float math functions in CUDA have the format f<op>f
syurkevi
requested changes
Sep 12, 2022
| ASSERT_ARRAYS_EQ(af::constant(1, shape, s64), rem); | ||
| ASSERT_ARRAYS_EQ(af::constant(0, shape, s64), diff); | ||
| } | ||
|
|
There was a problem hiding this comment.
test negative modulus, similar to halide/Halide#5773
| @@ -0,0 +1,183 @@ | |||
| /******************************************************* | |||
| * Copyright (c) 2014, ArrayFire | |||
|
|
||
| ASSERT_DOUBLE_EQ(norm_inf, result); | ||
| } | ||
|
|
There was a problem hiding this comment.
tests for vector norm?
atleast:
add TODO, open new issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for f16 for modulus and norm. This PR also adds tests for the norm function
Description
Fixes: #3256
Changes to Users
Checklist
[ ] Functions added to unified API[ ] Functions documented