New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'last day of prev month' selection #805
base: master
Are you sure you want to change the base?
Conversation
Set date after month/year in _updateDate
Add tests for selecting last day of old month and first day of new month
@arqex Any reason why this bug hasn't been fixed yet? I saw that this problem has existed, at least as far back as May. Hopefully this can be resolved in the near future. |
Thanks for providing this fix! (for now we'll apply it to our fork until it is merged) |
issue persists with latest version :( |
Yes, issue persist in the latest version |
The issue still persists with the latest version, any updates? :(
|
Description
Fix 'last day of prev month' date selection in DateTime's
_updateDate
method (fixes #804)Motivation and Context
Inside DateTime's
_updateDate
method, setting thedata-value
before the month/year causes unexpected behavior when a user selects the last day of the previous month. Switching the order resolves the issue.Checklist