Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onViewDateChange callback for when the viewed date changes #790

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JakeThurman
Copy link

These changes are equivalent to those in PR #403, but reapplied to the v3 codebase.
That pull request was closed for being stale.

Description

I added a callback that is triggered whenever the viewDate state value changes.

Motivation and Context

There is currently no way to respond to the visible period changing, for example if you need to data from the server in order to render the component.

In our application, we color-code the days in the days-of-the-month view. To do this we need to always be aware of what days are visible.

Checklist

  • I have not included any built dist files (us maintainers do that prior to a new release)
  • I have added tests covering my changes
  • All new and existing tests pass
  • My changes required the documentation to be updated
    • I have updated the documentation accordingly
    • I have updated the TypeScript type definitions accordingly

Questions

I wasn't sure what branch this should be targeting. Please let me know if I should change it to v3

@JakeThurman
Copy link
Author

@arqex Is there someone I can reach out to get this reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants