Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build issues related to npm v7 #758

Merged
merged 1 commit into from Dec 3, 2020

Conversation

vahissan
Copy link
Contributor

@vahissan vahissan commented Dec 2, 2020

Description

Travis CI build failed for PR #757 due to breaking changes introduced with npm v7. Here's the part of the log related to this issue.

$ npm install 
214npm ERR! code ERESOLVE
215npm ERR! ERESOLVE unable to resolve dependency tree
216npm ERR! 
217npm ERR! While resolving: react-datetime@3.0.4
218npm ERR! Found: react-dom@16.14.0
219npm ERR! node_modules/react-dom
220npm ERR!   dev react-dom@"^16.5.0" from the root project
221npm ERR! 
222npm ERR! Could not resolve dependency:
223npm ERR! peer react-dom@"^15.4.2" from react-addons-test-utils@15.6.2
224npm ERR! node_modules/react-addons-test-utils
225npm ERR!   dev react-addons-test-utils@">=0.13" from the root project
226npm ERR! 
227npm ERR! Fix the upstream dependency conflict, or retry
228npm ERR! this command with --force, or --legacy-peer-deps
229npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
230npm ERR! 
231npm ERR! See /home/travis/.npm/eresolve-report.txt for a full report.

The root cause for this issue was due to react-addons-test-utils which was not used anywhere. All test cases pass and the playground code runs fine after removing this package from devDependencies.

Checklist

[x] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[x] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly

@arqex arqex merged commit 7e30d6c into arqex:master Dec 3, 2020
@arqex
Copy link
Owner

arqex commented Dec 3, 2020

This is great, thanks for the PR @vahissan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants