Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add a snap flag to enable snapping to plausible steps on inc & dec in TimeView #603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JamesAlias
Copy link

@JamesAlias JamesAlias commented Nov 20, 2018

Description

I'm referencing the original issue from another repo here: neos/neos-ui#2247 to see where the idea originated.

I added a feature behind a flag called snap which when enabled slightly alters the way the increase and decrease methods of TimeView work.
The flag is optional and completely backwards compatible so there are no breaking changes.

Motivation and Context

When the user uses the today button he sets the time to now which, for example, could be 00:12.
With step for minutes set to 5 the increase or decrease buttons on minutes it will step to 00:17 or 00:07 respectively.
With snap enabled it will snap to the next plausible value depending on step, e.g. 00:15 and 00:10 respectively.

Checklist

  • I have not included any built dist files (us maintainers do that prior to a new release)
  • I have added tests covering my changes
  • All new and existing tests pass
  • My changes required the documentation to be updated
  • I have updated the documentation accordingly
  • I have updated the TypeScript 1.8 type definitions accordingly
  • I have updated the TypeScript 2.0+ type definitions accordingly

@jonnitto
Copy link

@YouCanBookMe is there a chance that you will merge this and make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants