Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new branch rk3576 to family rk35xx and armsom sige5 #6554

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amazingfate
Copy link
Contributor

@amazingfate amazingfate commented May 7, 2024

Description

There is no official SDK released for rk3576 so we have to use kernel and uboot from rockchip's internal (beta I guess) repo.
I wish this rk3576 family can get deleted when rockchip release new SDK for all rk35xx socs in the future.
I created kernel config based on rk35xx-vendor and enabled rk3576 soc support on top of it.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • ./compile.sh BOARD=armsom-sige5 BRANCH=vendor BUILD_DESKTOP=no BUILD_MINIMAL=no DEB_COMPRESS=xz KERNEL_CONFIGURE=no RELEASE=bookworm KERNEL_GIT=shallow
  • board boots fine

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@amazingfate amazingfate marked this pull request as draft May 7, 2024 10:01
@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related - kernel, u-boot, patches labels May 7, 2024
@amazingfate amazingfate changed the title new familt rk3576 and armsom sige5 new family rk3576 and armsom sige5 May 7, 2024
@amazingfate amazingfate marked this pull request as ready for review May 7, 2024 17:16
@amazingfate
Copy link
Contributor Author

We have to build uboot of rk3576 with BL32 blob, so I add env TEE to UBOOT_TARGET_MAP and add a patch to uboot to make use of this env.
And we have to use extlinux to boot kernel. boot.scr failed to execute.

@paolosabatino
Copy link
Contributor

paolosabatino commented May 8, 2024

ehm, do we really want again another rockchip family?

edit: after having a quick look into, and after having a refresh of what was my initial idea I expressed in the forum thread, I guess this is coherent with having a single and unique per-soc family addressing the vendor kernel.

@igorpecovnik
Copy link
Member

Agree. Its worth doing some extra work to keep it sane.

@amazingfate amazingfate marked this pull request as draft May 8, 2024 15:35
@amazingfate
Copy link
Contributor Author

I guess this is coherent with having a single and unique per-soc family addressing the vendor kernel

We will merge work of rk3576 to rk35xx-vendor after rockchip's releases SDK for rk3528/rk356x/rk3588/rk3576. So another choice is adding a new branch rk35xx-vendor-rk3576 like rk35xx-vendor-boogie-panthor @rpardini added.

@rpardini
Copy link
Member

like rk35xx-vendor-boogie-panthor @rpardini added

btw AF I think that BRANCH might be removed? If I understand, you've operated the magics needed to have panthor as an option directly in the vendor BRANCH and thus vendor-boogie-panthor is no longer necessary?

@amazingfate
Copy link
Contributor Author

like rk35xx-vendor-boogie-panthor @rpardini added

btw AF I think that BRANCH might be removed? If I understand, you've operated the magics needed to have panthor as an option directly in the vendor BRANCH and thus vendor-boogie-panthor is no longer necessary?

That branch lacks maintenance, but it provides an out-of-box panthor image. It's better to update documents on how to toogle panthor driver with vendor kernel if we delete that.

@rpardini
Copy link
Member

That branch lacks maintenance, but it provides an out-of-box panthor image.

Indeed, I won't have the cycles to keep it updated.

It's better to update documents on how to toogle panthor driver with vendor kernel if we delete that.

Ooops, I already sent the removal (and it was merged very fast)...

From what I could gather in armbian/linux-rockchip#171 we could come up with an panthor extension that:

  1. Enables the panthor-gpu overlay by default
  2. Adds obibaf-mesa extension

Anything else?

Thanks for the help and sorry for the hijack of this PR

@amazingfate
Copy link
Contributor Author

  • Enables the panthor-gpu overlay by default
  • Adds obibaf

That would be enough.

@amazingfate amazingfate changed the title new family rk3576 and armsom sige5 new branch rk3576 to family rk35xx and armsom sige5 May 14, 2024
@amazingfate
Copy link
Contributor Author

  • Add a new branch rk3576 to rk35xx.
  • Enable RK806 I2C.
  • Diable panfrost because there will be kernel panic when probing it.

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress 08 Milestone: Third quarter release labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Hardware Hardware related - kernel, u-boot, patches size/large PR with 250 lines or more Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants