init: set the HOME env var if root #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When virtme-ng was running as root, the HOME dir was set to '/'. Now it is set to '/root', the expected value. Fixes: bcd99d9 ("virtme-init: docker host support") Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
|
This has been already applied by updating the virtme-ng-init module (sorry I missing this PR...). Closing for now, thanks. |
|
Thank you for having merged the other PR. But I think you missed the updated of the old init script. I can rebase and re-open a new one. |
|
Ah you're right! Yes, please, if you can rebase I'll apply this one as well. Thanks! |
|
All good, done in #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When virtme-ng was running as root, the HOME dir was set to '/'.
Now it is set to '/root', the expected value.
Fixes: bcd99d9 ("virtme-init: docker host support")
Note: this PR depends on arighi/virtme-ng-init#7