Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: do not stop if the .config file is present #91

Merged
merged 3 commits into from Mar 19, 2024
Merged

config: do not stop if the .config file is present #91

merged 3 commits into from Mar 19, 2024

Commits on Mar 18, 2024

  1. config: always append virtme configs 

    Otherwise, the 'virtme-configkernel --update' command doesn't really
make sense if it doesn't update an existing kernel config file.

Note that 'vng -b' and 'vng -k' will call 'virtme-configkernel --update'.
It is not clear if the kconfig update is skipped on purpose or not, but
it looks confusing not to do anything.

Fixes: 6ade5a7 ("virtme: improve configkernel")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
    @matttbe
    matttbe committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d63552c View commit details
    Browse the repository at this point in the history

  2. config: override the kernel config if asked 

    When '--defconfig' is used (or --allnoconfig), the kernel config is
supposed to be overridden. It was only done if there was no .config
file.

Now the kernel config is always overridden if asked.

Fixes: 6ade5a7 ("virtme: improve configkernel")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
    @matttbe
    matttbe committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2f07be9 View commit details
    Browse the repository at this point in the history

  3. config: option not to update if there is a config file 

    The '--update' option of virtme-configkernel is there to "update
existing config for virtme" according to the help message.

vng was calling 'virtme-configkernel --update', but the goal was not to
modify the config file if it was present, just in case it has been
modified in between two build calls. To support that, the '--update'
option had been modified ... not to update the config file if it was
present, in contradiction with the option name and its 'help' text.

A new '--no-update' parameter is now available: if the config file
exists, nothing is done. 'vng' is then now calling:

  virtme-configkernel --defconfig --no-update

So if the config file exists, the config is not modified, but a message
is now printed in stdout (only visible when vng is used with --verbose).

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
    @matttbe
    matttbe committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2dda460 View commit details
    Browse the repository at this point in the history