Skip to content

Commit

Permalink
qemu: remove unnecessary '-serial none' arg
Browse files Browse the repository at this point in the history
When not using the --graphics mode, or without the script options, QEmu
was always launched with:

  -serial none -serial chardev:console

'-serial none' means "don't allocate this serial device". Here, it is
directly overridden by another serial. Best not to declare '-serial none'
then.

Since QEmu 8.2.2, having '-serial none -serial <something>' is no longer
supported, and it is then recommended to remove the unnecessary '-serial
none' [1]. It continues to work on previous versions (tested on 8.2.1).

Reported-by: @tehcaster
Closes: #97
Link: https://lore.kernel.org/qemu-devel/20240122163607.459769-2-peter.maydell@linaro.org/ [1]
Suggested-by: @ishitatsuyuki
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
  • Loading branch information
matttbe committed Mar 27, 2024
1 parent 6fad769 commit 4aab16e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion virtme/commands/run.py
Expand Up @@ -1001,7 +1001,6 @@ def do_it() -> int:

if args.graphics is None and not args.script_sh and not args.script_exec:
qemuargs.extend(["-echr", "1"])
qemuargs.extend(["-serial", "none"])

if args.verbose:
# Check if we have permission to access the current stderr.
Expand Down

0 comments on commit 4aab16e

Please sign in to comment.