Provide fallback implementation for getentropy() #2000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ba3396f changed getRandomBytes() implementation from c++ std uniform distribution to getentropy(). The getentropy() function first appeared in glibc 2.25. In order to provide backward compatibility for older glibc (e.g. Android SDK <= 19) restore previous getRandomBytes() implementation as a fallback.
Testing
Right now compilation succeeds with NDK r19c: https://github.com/android/ndk/wiki/Unsupported-Downloads#r19c