Update condition to select right pvc as child for statefulset

[hanzala1234]

We have 2 pvc in namespace, one with name emqx-data-sw-broker-0 for statefulset sw-broker and other one is emqx-data-sw-broker-internal-0 for statefulset sw-broker-internal and both have same template name emqx-data. since emqx-data-sw-broker-internal-0 contains prefix emqx-data-sw-broker-, it consider it as part of sw-broker statefulset which is not right. fixing condition to check if it contains number at the end of prefix

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[bradenwright]

Any updates on this, I've experienced this issue as well and it would be nice to get it resolved.

[bradenwright]

any update on this issue?

[bradenwright]

any update on this? It's a bug fix and its been open for over 4 months

[pasha-codefresh]

@hanzala1234 thank you for your contribution.

Could you please cover your changes with tests and also could you please add example yamls so i can test the fix locally?

[bradenwright]

i know @hanzala1234 did the work along with my company, I can try to take a look at that. I should have time this week (I'm gonna be traveling tomorrow).

[pasha-codefresh]

Thank you @bradenwright

[bradenwright]

I've had a few fires pop up this week, so it will probably be a week or 2 til I have time to look into this.

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[nerdeveloper]

Hello @pasha-codefresh We have added some test cases/examples into the code, it is good to review now

[nerdeveloper]

Just another reminder that need to be checked please @pasha-codefresh

[pasha-codefresh]

@nerdeveloper will review it tomorrow, sorry, didnt notice your msg

[pasha-codefresh]

Looks great for me, just doing manual testing and will merge it

[pasha-codefresh]

Issue is resolved, LGTM!

[pasha-codefresh]

@hanzala1234 , thank you for your contribution, feel free to open ArgoCD PR with gitops-engine version update, you can assign or tag me, i will review it

[hanzala1234]

thanks @pasha-codefresh for merging MR. I will work on it tomorrow