Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarification/typo in tutorial #4810

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

sdiazlor
Copy link
Contributor

@sdiazlor sdiazlor commented May 8, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #4809

Type of change

(Remember to title the PR according to the type of change)

  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes.)

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@sdiazlor sdiazlor changed the title docs: clarificationt/ypo in tutorial docs: clarification/typo in tutorial May 8, 2024
@sdiazlor sdiazlor requested a review from nataliaElv May 8, 2024 15:02
Copy link
Member

@nataliaElv nataliaElv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Before merging, could you wait until today's release is out? I think there shouldn't be any conflicts in the pages you changed, but just in case I think it's best to wait for the new version and then merge these changes. Thanks!

@sdiazlor sdiazlor merged commit e466946 into main May 13, 2024
17 checks passed
@sdiazlor sdiazlor deleted the docs/clarificationtypo-in-tutorial branch May 13, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants