Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overlap equal to number of users in assign_users #4792

Conversation

kdutia
Copy link

@kdutia kdutia commented May 7, 2024

Description

In assign_records it's currently not possible to assign all records to all users. I can't see a reason why this would be the case (it's something my team need at the moment), so I've updated the code to allow this and to warn if all records will be assigned to all users.

Note I'm still setting up a dev environment on my machine (with pip install the integrations dependencies take ages to resolve), so I haven't confirmed that my test works.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Updated existing test with a new test case

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@sdiazlor
Copy link
Contributor

sdiazlor commented May 14, 2024

Hi @kdutia, thanks for your PR. However, assigning all records to all users is the default behavior you can use without the need for assign_records. If this is how you want to distribute your workload, you just need to create a dataset in a workspace and let the users with the role annotator access it, so they will be able to provide feedback for all the records in that dataset.

Let us know if that would work for your use case :)

@kdutia
Copy link
Author

kdutia commented May 20, 2024

@sdiazlor thanks for this advice! Does that mean that each record in one workspace can be annotated by multiple annotators by default? It could be useful to update the documentation around assign_users to give this advice for this specific case, or even add an instructional warning when someone tries to do this .

@sdiazlor
Copy link
Contributor

sdiazlor commented May 20, 2024

@kdutia Thanks for the feedback! Yes, if you allow your annotators to access and annotate the same dataset, you'll be able to get multiple annotations.

@kdutia
Copy link
Author

kdutia commented May 23, 2024

@sdiazlor Ok, I'd suggest a documentation update to make this clearer but I'll close this PR. Thanks for your help!

@kdutia kdutia closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants