Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Review Developer docs #4776

Merged
merged 13 commits into from May 16, 2024

Conversation

frascuchon
Copy link
Member

Description

This PR reviews the development docs related to this new mono repo structure. I realized that some of those docs were outdated. These docs will be revisited in future PRs.

Type of change

(Remember to title the PR according to the type of change)

  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes.)

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link
Member

@nataliaElv nataliaElv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some comments here :)

docs/_source/community/developer_docs.md Outdated Show resolved Hide resolved
docs/_source/community/developer_docs.md Outdated Show resolved Hide resolved
docs/_source/community/developer_docs.md Outdated Show resolved Hide resolved
docs/_source/community/developer_docs.md Outdated Show resolved Hide resolved
docs/_source/community/developer_docs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sdiazlor sdiazlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add that these references don't work:

@frascuchon
Copy link
Member Author

@nataliaElv @sdiazlor the changes are ready to review.

Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4776-ki24f765kq-no.a.run.app

@frascuchon frascuchon merged commit 746c516 into ci/configure-mono-repo May 16, 2024
11 checks passed
@frascuchon frascuchon deleted the docs/review-developer-docs branch May 16, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants