Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timestamp from epics inside while(acquire) loop #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jsouter
Copy link

@jsouter jsouter commented Nov 14, 2023

Previously noticed that all frames have identical timestamps, the startTime timestamp only gets updated in the first while loop, so within while (acquire) block timestamps are currently the same if collecting more than a single frame.

e: after discussing with @coretl I will push again to this so that the timestamp uses EpicsTS, as the two timestamps are currently separated by some lines of code.

@MarkRivers
Copy link
Member

@jsouter I commented on one of your PRs this morning, saying that I created a new asynNDArrayDriver::updateTimeStamps() method. I can’t remember which repository I did that in.

For drivers that update NDArray.timeStamp from the camera info you will need to call the new method first, and then update with the camera timestamp.

@jsouter
Copy link
Author

jsouter commented Nov 17, 2023

Thanks Mark, I think most of the PRs I've sent so far have just been for the detectors that don't use a hardware time stamp, but I've made note of which other detectors will need changing too. I will update these PRs to use the new updateTimeStamps() method soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants