Check for 7 OK message when waiting for an image to actualy end the acquisition #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cquisition Sometimes a 15 OK message gets intermixed and prematurely ends the busy record when acquiring images, this can lead to synchronization problems
There was a problem hiding this comment.
This looks like a fix for some intermittent issues I'm having with some ADPilatus. I might try this as soon as I have the opportunity.
@auriocus do you think this is also needed for the multiple image case, that you can find on line 1268?
Cheers,
Armando Pueyos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, the driver continues to wait for the acknowledgement that the image acquisition has ended (7 OK message). Before that, the driver assumed the end of acquisition upon receipt of any arbitrary message from the camserver. Sometimes a "15 OK" was stuck / delayed in our system and caused the driver to assume that the image was taken, which caused synchronization problems.