Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: let the upload run when no board is selected #2387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: let the upload run when no board is selected #2387

wants to merge 1 commit into from

Conversation

kittaakos
Copy link
Contributor

Motivation

IDE2 must not disable the upload from the UI when no board is selected. Otherwise, IDE2 does not receive the no FQBN error from the CLI and cannot suggest selecting a board via the Tools > Board menu.

Change description

Other information

Closes #1714

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: let the upload run when no board is selected
3c5c014 
IDE2 must not disable the upload from the UI when no board is selected.
Otherwise, IDE2 does not receive the `no FQBN` error from
the CLI and cannot cannot
suggest selecting a board via the `Tools` > `Board` menu.

Closes #1714

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 23, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomocusinato giacomocusinato giacomocusinato approved these changes

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload fails silently when no board is selected
3 participants
@kittaakos @CLAassistant @giacomocusinato