Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close WebSocket connection after closing Serial Plotter #1702

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Close WebSocket connection after closing Serial Plotter #1702

wants to merge 1 commit into from

Conversation

francescospissu
Copy link
Contributor

Motivation

After closing the Serial Plotter the serial port remains open.

Change description

Disconnect WebSocket when closing Serial Plotter window.

Other information

Closes #1423.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@francescospissu francescospissu self-assigned this Nov 21, 2022
@francescospissu francescospissu added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@francescospissu francescospissu

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port left open after closing Serial Plotter
2 participants
@francescospissu @kittaakos