Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Force prefix on protected types #6007

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SGudbrandsson
Copy link

Enables users to force prefixes on protected types to make migration to GraphQL Mesh seamless

馃毃 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

This change adds an optional force parameter to the prefix transformation.
The force parameter should contain a list of strings.

This change makes it easier to migrate from custom GraphQL gateways that have prefixed custom types.

This enables us to migrate our gateway slowly without breaking the schema for the clients.

Fixes #6002

Type of change

Please delete options that are not relevant.

  • [ X] New feature (non-breaking change which adds functionality)
  • [ X] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-mesh/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

Enables users to force prefixes on protected types to make migration to GraphQL Mesh seamless
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

鈿狅笍 No Changeset found

Latest commit: 8c136cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable prefixing protected scalars when prefixing upstream data
1 participant