Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Slider): make SliderButton moves with the mouse when the SliderButton quickly jumps to the mouse click. #2623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swnb
Copy link

@swnb swnb commented Apr 8, 2024

Make SliderButton moves with the mouse when the SliderButton quickly jumps to the mouse click.

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Documentation change
  • Coding style change
  • Component style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change
  • Others

Background and context

When clicking on the blank space of Slider,Slider quickly jumps to the mouse click,But it will not follow the mouse movement, You have to click the SliderButton one more time, antd does not have this problem

This pr makes the SliderButton follow the mouse movement when jumping

relate issue 2622

Solution

当点击 Slider 触发 jumpClick 的时候,触发对应 SliderButton 的 mouseDown 事件

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
Slider 当SliderButton 跳转到鼠标点击处时,可以跟随鼠标直接做拖拽运动 SliderButton moves with the mouse when the SliderButton quickly jumps to the mouse click. 2622

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

Copy link

codesandbox bot commented Apr 8, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

github-actions bot commented Apr 8, 2024

Prepare preview

Copy link

codesandbox-ci bot commented Apr 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@swnb swnb changed the title feat(Slider): SliderButton moves with the mouse when the SliderButton… feat(Slider): make SliderButton moves with the mouse when the SliderButton quickly jumps to the mouse click. Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant