Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: detect the dataIndex type in table #2317

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

types: detect the dataIndex type in table #2317

wants to merge 3 commits into from
+44 −17

Conversation

chenzn1
Copy link
Contributor

@chenzn1 chenzn1 commented Oct 27, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Documentation change
  • Coding style change
  • Component style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change
  • Others

Background and context

Solution

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
Table 给 Column.dataIndex 增加类型提示

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

@github-actions
Copy link

Prepare preview

@yinkaihui
Copy link
Contributor

ts 编译直接报错了，麻烦再看下呢

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 27, 2023 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a20764c:

Sandbox Source
arco-react-pr-template Configuration

@chenzn1
Copy link
Contributor Author

chenzn1 commented Oct 28, 2023

ts 编译直接报错了，麻烦再看下呢

Fixed.

@chenzn1 chenzn1 changed the title feat: add type to dataIndex in table types: add type to dataIndex in table Oct 30, 2023
@chenzn1 chenzn1 changed the title types: add type to dataIndex in table types: detect the dataIndex type in table Oct 30, 2023
@chenzn1
Copy link
Contributor Author

chenzn1 commented Oct 31, 2023

@yinkaihui

@chenzn1
Copy link
Contributor Author

chenzn1 commented Nov 6, 2023

@yinkaihui 可以合并吗，还是说有什么问题？

@yinkaihui
Copy link
Contributor

@yinkaihui 可以合并吗，还是说有什么问题？

抱歉。。 review 的忘记提交了

@chenzn1 chenzn1 force-pushed the types/table-types branch 2 times, most recently from a0367a9 to 9103d3b Compare November 6, 2023 08:30
@yinkaihui
Copy link
Contributor

代码冲突了，需要解决下

@chenzn1
Copy link
Contributor Author

chenzn1 commented Dec 27, 2023

代码冲突了，需要解决下

解决了。 @yinkaihui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinkaihui yinkaihui yinkaihui left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenzn1 @yinkaihui