fix(Trigger): 修复当body存在zoom并且弹出层位于视图右侧边界时，弹出层向左偏移 #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prepare preview |
yinkaihui
reviewed
Aug 25, 2023
| const windowHeight = document.documentElement?.clientHeight || window.innerHeight; | ||
| const windowWidth = document.documentElement?.clientWidth || window.innerWidth; | ||
| const windowHeight = document.documentElement?.clientHeight / bodyZoom || window.innerHeight; | ||
| const windowWidth = document.documentElement?.clientWidth / bodyZoom || window.innerWidth; | ||
|
|
There was a problem hiding this comment.
不需要计算 zoom 的值，直接通过 document.documentElement.getboundingdocument.documentElement.getBoundingClientRect 获取宽度高度即可？ getBoundingClientRect 返回的尺寸就是 zoom 后的尺寸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Background and context
Solution
How is the change tested?
Changelog
Checklist:
npm run test)featurebranch and others should be submitted tomainbranch)Other information