Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): 🐛 表格扩展components优化 #2165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tipsxBase
Copy link

@tipsxBase tipsxBase commented Aug 21, 2023

当扩展body.wrapper或header.wrapper时需要支持ref,但是forwardRef类型的React组件的类型是对象
image
,如果使用lodash.merge时会导致forwardRef的类型进行跟传入的类型不一致,导致wrapper组件重新渲染时每次都会重新挂载,导致ref找不到

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Documentation change
  • Coding style change
  • Component style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change
  • Others

Background and context

Solution

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

当扩展body.wrapper或header.wrapper时需要支持ref,但是forwardRef类型的React组件的类型是对象,如果使用lodash.merge时会导致forwardRef的类型进行跟传入的类型不一致,导致wrapper组件每次都会重新挂载,导致ref找不到
@github-actions
Copy link

Prepare preview

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97716e7:

Sandbox Source
arco-react-pr-template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants