Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dayjs.ts #2114

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update dayjs.ts #2114

wants to merge 2 commits into from

Conversation

vaynevayne
Copy link

resolve #2113

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Documentation change
  • Coding style change
  • Component style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change
  • Others

Background and context

Solution

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Prepare preview

@vaynevayne
Copy link
Author

bug: 未考虑到 dayjs 对象是dayjs.utc的情况 , 此时取值时需要使用 dayjs.utc(value).valueOf(),而不是 dayjs(value).valueOf()

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d97d6b8:

Sandbox Source
arco-react-pr-template Configuration
agitated-bash-8sqf5l Issue #2113
预设范围 - antd@5.7.3 (forked) Issue #2113

@PengJiyuan
Copy link
Member

这个用 dayjs 包一层是为了解决一种场景,如果不同实例的 dayjs 对象传过来,能保证转成内部所用的 dayjs 实例。

@vaynevayne
Copy link
Author

vaynevayne commented Aug 4, 2023

6, 那就这样改, 你看下 @PengJiyuan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DatePickRange]: 预设不支持 dayjs.utc
2 participants