Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure the width of useEllipsis is latest when resize is trig… #2011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ederzz
Copy link
Contributor

@ederzz ederzz commented Jun 4, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Documentation change
  • Coding style change
  • Component style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change
  • Others

Background and context

If the resize event interval is less than 100ms, text ellipsis is incorrect.

Solution

Replace difftime judgement with debounce.

But i dont know the meaning of measureStatus-check, can you explain it?

const resizeStatus = [MEASURE_STATUS.NO_NEED_ELLIPSIS, MEASURE_STATUS.MEASURE_END];
if (resizeStatus.includes(measureStatus)) {

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Prepare preview

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9917f8:

Sandbox Source
arco-react-pr-template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant