Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace init, dependencies command with js script #2009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ederzz
Copy link
Contributor

@ederzz ederzz commented Jun 3, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Documentation change
  • Coding style change
  • Component style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change
  • Others

Background and context

For non-unix users, running sh script would be a problem.

Solution

Replace sh script with js.

How is the change tested?

No problem.

Changelog

Component Changelog(CN) Changelog(EN) Related issues

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Prepare preview

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a62620:

Sandbox Source
arco-react-pr-template Configuration

@ederzz
Copy link
Contributor Author

ederzz commented Jun 29, 2023

Is there anything wrong with the pr? @yinkaihui

@MisterLuffy
Copy link
Member

Why this change is necessary? Is there any problem with init project via shell?

@ederzz
Copy link
Contributor Author

ederzz commented Jul 21, 2023

Why this change is necessary? Is there any problem with init project via shell?

I can't run .sh file on Windows platform, node script would be a better choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants