Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the current layout instead of the us layout #2495

Merged
merged 2 commits into from May 15, 2024

Conversation

ngn13
Copy link
Contributor

@ngn13 ngn13 commented May 10, 2024

  • This fix issue: none

PR Description:

By default, the installer selects the "us" layout. With this simple enhancement, it selects the current layout (acquired by parsing localectl status output) instead of "us".

So if the user runs loadkeys or localectl set-keymap before running archinstall, they won't have to set their keymap again.

Tests and Checks

  • I have tested the code! (on my local machine, there is no link to the ISO)

@ngn13 ngn13 requested a review from Torxed as a code owner May 10, 2024 16:14
Copy link
Member

@Torxed Torxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I don't see a reason for not setting the default to whatever the user has provided before launching archinstall.

@svartkanin
Copy link
Collaborator

looks good thanks for that!

@svartkanin svartkanin merged commit 39d096b into archlinux:master May 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants