Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dosfstools to the PKGBUILD depends #2439

Merged
merged 1 commit into from May 25, 2024

Conversation

digital-raven
Copy link
Contributor

@digital-raven digital-raven commented Mar 28, 2024

One of the tools needed by archinstall is mkfs.fatXX and this wasn't automatically installed.

  • I don't know if this issue is present on the github. I'll open one if required; the contributing guideline did not impose a requirement for an existing issue.

PR Description:

This adds dosfstools, which provides the mkfs.fat binary which is used in device_handler.py

Tests and Checks

When I run makepkg -s on my system with or without this change, I receive an error that my build did not pass the "validity check". I don't know if this has bearing on the integrity of this change, so I left the following checklist for what I believe would be a good test of this change.

  • Using archinstall as installed using pacman -S archinstall and try to format any partition using a code path that relies on mkfs.fat, archinstall will error because this tool is not installed.
  • When I ran makepkg -si, dosfstools was installed on my system along with archinstall.

One of the tools needed by archinstall is mkfs.fatXX and this wasn't automatically installed.
@digital-raven
Copy link
Contributor Author

Hey guys, I'm still watching this! It's not a big deal for me personally as I was able to just install it and that's a decent workaround, but this is something that I think a newer user would be intimidated by were they to use archinstall on its own. I think it's a short and sweet improvement.

@svartkanin
Copy link
Collaborator

Are you saying that it's missing on the ISO or that it could be missing when running archinstall on another system?

@digital-raven
Copy link
Contributor Author

It's missing when running archinstall on another system. If dosfstools is not already present, then pacman -S archinstall will not install it, and it's a necessary tool for archinstall's operation.

@svartkanin
Copy link
Collaborator

I think in that guess it's reasonable to include it in the configuration

@svartkanin svartkanin merged commit 6863994 into archlinux:master May 25, 2024
5 checks passed
@Torxed
Copy link
Member

Torxed commented May 25, 2024

IT doesn't hurt to add it, if it's used to bootstrap a VM for instance from an existing system.
But we've gotten lucky that the ISO releng has it shipped automatically.

@svartkanin
Copy link
Collaborator

I assumed it should as it's a requirement for it to work on the iso, but I didn't check to make sure. Thanks @Torxed for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants