QA-531: start implementing single-shard dump/restore #20827
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dothebart
changed the title
naushniki
approved these changes
Apr 10, 2024
Base automatically changed from
bug-fix-3.11/fix-agent-upgrade-alternative-with-rta
to
3.11
April 10, 2024 12:18
jsteemann
reviewed
Apr 11, 2024
| @@ -44,6 +44,12 @@ if (isEnterprise) { | |||
| egm = require("@arangodb/enterprise-graph"); | |||
| } | |||
|
|
|||
| function getNoShards(defaultNo) { | |||
There was a problem hiding this comment.
I am not against adding this function and using it in the tests.
But the devel version of this PR did not add such function, and I currently do not see an open devel PR that would add it.
So why is this function added only in 3.11? Do we need to add it in a separate devel PR?
dothebart
force-pushed
the
tests/single-shard-dump
branch
from
930ee3b
to
b9c442a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
(Please describe the changes in this PR for reviewers, motivation, rationale - mandatory)
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)