small optimizations for AqlItemBlock::toVelocyPack() #20739
Merged
+77
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use FlatHashMap and not std::unordered_map to remember already seen objects. FlatHashMap should be slightly faster because the table is stored in contiguous memory - instead of using a sequence of table.find(value) and table.emplace(value, pos), we are now doing unconditional try_emplaces into the table. in case the target element was already in the table, this does nothing. in case the target element was not yet in the table, the call will create it, and we will have saved the additional call to find()
…lock-tovelocypack
…/small-optimization-for-aqlitemblock-tovelocypack
…lock-tovelocypack
goedderz
approved these changes
May 14, 2024
…lock-tovelocypack
mchacki
deleted the
performance/small-optimization-for-aqlitemblock-tovelocypack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
small optimizations for AqlItemBlock::toVelocyPack()
sanitizeNonClientTypesby removing the boolean parameters that were always set totrueanyway on all call sites. Additionally, pass the velocypack::Options parameter by reference so that we can avoid nullptr-checks later.these changes should not alter the observable behavior in any way.
observed performance improvements for toVelocyPack() are around ~1% with these changes for a test set of values.
Checklist
Related Information