fix(analyze): support signatures based on signatures #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlonZivony
force-pushed
the
feature/support-sigs-on-sigs-tracee-rules
branch
from
3d855d9
to
17b13e0
Compare
Change the current analyze mode to support signatures based on signatures. The overall logic now should be much more similar to that of tracee. sync: latest libbpf changes from kernel Syncing latest libbpf commits from kernel repository. Baseline bpf-next commit: 155addf0814a92d08fce26a11b27e3315cdba977 Checkpoint bpf-next commit: 750011e239a50873251c16207b0fe78eabf8577e Baseline bpf commit: 83b9dda8afa4e968d9cce253f390b01c0612a2a5 Checkpoint bpf commit: bc4fbf022c68967cb49b2b820b465cf90de974b8 Andrii Nakryiko (2): bpf: add register bounds sanity checks and sanitization bpf: rename BPF_F_TEST_SANITY_STRICT to BPF_F_TEST_REG_INVARIANTS Jordan Rome (1): bpf: Add crosstask check to __bpf_get_stack include/uapi/linux/bpf.h | 6 ++++++ 1 file changed, 6 insertions(+) Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
AlonZivony
force-pushed
the
feature/support-sigs-on-sigs-tracee-rules
branch
from
17b13e0
to
7898a36
Compare
geyslan
reviewed
Apr 30, 2024
AlonZivony
force-pushed
the
feature/support-sigs-on-sigs-tracee-rules
branch
2 times, most recently
from
208b923
to
e566de3
Compare
|
Hey @AlonZivony I think this is good for merging right? Could you just rebase again? |
geyslan
reviewed
May 23, 2024
Comment on lines
+71
to
+72
|
|
||
| go sigEngine.Start(ctx) |
geyslan
reviewed
May 23, 2024
| for _, eventName := range eventsToPrint { | ||
| eventsToPrintMap[eventName] = struct{}{} | ||
| } | ||
| go func() { |
There was a problem hiding this comment.
nit: move the (156 line) wg.Add(1) to here, just before go func().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Support signatures based on signatures in the analyze mode.
This is done in the purpose of making all signatures that are compatible with tracee to be also compatible with the analyze mode.
Fix #4009
2. Explain how to test it
3. Other comments