New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps #3999
base: main
Are you sure you want to change the base?
Bumps #3999
Conversation
7c68951
to
ba12bdd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ac8e0e4
to
5cdcf8a
Compare
After this be merged. A sequential PR should be created bumping the main
So, only after that, we should update internal tests. |
@josedonizetti you may notice in f2d6129 that I pinned the protoc version to ensure that the generated files are not modified. But I would like to know if there is no synchronization problem with the client side when updating the versions of these files. If there's, what should be the steps to take? Or would you take care of bumping the protoc in a different PR? |
api/go.mod
Outdated
@@ -1,16 +1,15 @@ | |||
module github.com/aquasecurity/tracee/api | |||
|
|||
go 1.21 | |||
go 1.22.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a silly question, but why do we need to specify the patch version? won't 1.22
be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I should be using the toolchain directive here like:
go 1.22.0 // doesn't enforce any specific patch version, but doesn't limit it to 1.22.0 as minor.
toolchain go1.22.3 // do enforce this specific patch version
It's sane to make the whole environment to use the same version (patch or not).
grpc pkg introduced NewClient in v1.63.0. SA1019 grpc.Dial is deprecated: use NewClient instead. Will be supported throughout 1.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rscampos Thanks for reviewing it. I'm holding it for a while since it's good to have @NDStrahilevitz and @josedonizetti feedback as well, since it will demand changes to internal tests and beyond. |
This doesn't upgrade versions to avoid changes in the protoc output which would require updating the generated code.
It also updates all man by generating them with the new pandoc version.
1. Explain what the PR does
cdf51f4 chore(deps): bump go to 1.22.3
015e29b chore(builder): bump pandoc to 3.2
5bfb528 chore(builder): pin protoc versions
5170c47 chore: use NewClient instead of Dial (deprecated)
08ab832 chore: bump go.mod and go.sum
01c3539 chore(signatures): bump go.mod and go.sum
f6ccb30 chore(types): bump go.mod and go.sum
45bb393 chore(api): bump go.mod and go.sum
015e29b chore(builder): bump pandoc to 3.2
5bfb528 chore(builder): pin protoc versions
5170c47 chore: use NewClient instead of Dial (deprecated)
2. Explain how to test it
3. Other comments