Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo and snapshots packages filter api add 'maximumVersion' query parameter support #1285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 21, 2024

repo and snapshots packages filter api add 'maximumVersion' query parameter support

example: curl http://localhost:8080/api/repos/test/packages\?maximumVersion\=1

Change-Id: Ie9ffd36146bf017bbb353737f32360f7b73d6b0a

Replaces #1088

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx self-assigned this Apr 21, 2024
@neolynx neolynx force-pushed the feature/maximumVersion-filter branch from 2e7f501 to 6691b79 Compare April 21, 2024 13:00
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 74.74%. Comparing base (8d09c20) to head (b7e3e3e).
Report is 1 commits behind head on master.

Files Patch % Lines
api/api.go 8.69% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   74.79%   74.74%   -0.05%     
==========================================
  Files         144      144              
  Lines       16256    16271      +15     
==========================================
+ Hits        12158    12162       +4     
- Misses       3156     3169      +13     
+ Partials      942      940       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx added fix tests Tests are failing increase coverage The PR lacks test coverage and removed fix tests Tests are failing labels Apr 21, 2024
@neolynx neolynx requested review from mfolusiak, szakalboss and a team April 21, 2024 13:37
@neolynx neolynx added the needs review Ready for review & merge label Apr 21, 2024
@neolynx neolynx force-pushed the feature/maximumVersion-filter branch from 6691b79 to c9d9a37 Compare April 24, 2024 14:54
…ry parameter support

example: `curl http://localhost:8080/api/repos/test/packages\?maximumVersion\=1`

Change-Id: Ie9ffd36146bf017bbb353737f32360f7b73d6b0a
@neolynx neolynx force-pushed the feature/maximumVersion-filter branch from c9d9a37 to b7e3e3e Compare April 24, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
increase coverage The PR lacks test coverage needs review Ready for review & merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants