Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database backend add ssdb support #1280

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 20, 2024

Replaces #1115

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx added needs review Ready for review & merge needs rebase The PR needs to be rebased on master fix tests Tests are failing and removed needs review Ready for review & merge labels Apr 20, 2024
@neolynx neolynx removed the needs rebase The PR needs to be rebased on master label Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 71.24011% with 109 lines in your changes are missing coverage. Please review.

Project coverage is 74.62%. Comparing base (27013c0) to head (e66edb6).
Report is 2 commits behind head on master.

❗ Current head e66edb6 differs from pull request most recent head 88d4563. Consider uploading reports for the commit 88d4563 to get more accurate results

Files Patch % Lines
database/ssdb/storage.go 64.60% 31 Missing and 9 partials ⚠️
database/ssdb/transaction.go 81.60% 19 Missing and 4 partials ⚠️
context/context.go 12.00% 20 Missing and 2 partials ⚠️
database/ssdb/database.go 55.55% 12 Missing and 4 partials ⚠️
database/ssdb/batch.go 93.42% 4 Missing and 1 partial ⚠️
database/ssdb/log.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   74.78%   74.62%   -0.17%     
==========================================
  Files         144      149       +5     
  Lines       16246    16594     +348     
==========================================
+ Hits        12150    12383     +233     
- Misses       3154     3246      +92     
- Partials      942      965      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx requested review from mfolusiak, szakalboss and a team April 21, 2024 11:09
@neolynx neolynx added needs review Ready for review & merge increase coverage The PR lacks test coverage and removed fix tests Tests are failing labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
increase coverage The PR lacks test coverage needs review Ready for review & merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants