Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagged version of ProtonMail/go-crypto in go.mod #1279

Merged
merged 1 commit into from
May 15, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 20, 2024

Replaces #1253

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.81%. Comparing base (8d09c20) to head (fd1a7ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
+ Coverage   74.79%   74.81%   +0.02%     
==========================================
  Files         144      144              
  Lines       16256    16248       -8     
==========================================
- Hits        12158    12156       -2     
+ Misses       3156     3152       -4     
+ Partials      942      940       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx requested review from mfolusiak, szakalboss and a team April 20, 2024 21:55
@neolynx neolynx added the needs review Ready for review & merge label Apr 20, 2024
@neolynx neolynx force-pushed the fix/use-tagged-proton-crypto branch 2 times, most recently from eff8a3f to 665a3e0 Compare April 24, 2024 14:57
@neolynx neolynx force-pushed the fix/use-tagged-proton-crypto branch from 665a3e0 to fd1a7ae Compare April 24, 2024 15:40
@neolynx neolynx removed the needs review Ready for review & merge label May 15, 2024
@neolynx neolynx merged commit 5353890 into master May 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants