Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CodeCov Pipeline #1165

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

reglim
Copy link
Contributor

@reglim reglim commented Mar 17, 2023

The code coverage has had some issues in the past, which are addressed by this change.

Fixes: #1164

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

I changed the go test command to output to the GOCOVERDIR and upgraded the ci to go version 1.20.
I also had to fix some issues that the linter detected, mainly replacing unused parameters with _.

Why this change is important?

The coverage should be accurate and it's not bad to test on the latest go version either.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@reglim reglim force-pushed the fix/1164-fix-codecov-pipeline branch 24 times, most recently from 28578ea to be59569 Compare March 21, 2023 09:52
@reglim reglim force-pushed the fix/1164-fix-codecov-pipeline branch 6 times, most recently from 8ffce2e to 676caa0 Compare March 31, 2023 14:35
@reglim reglim force-pushed the fix/1164-fix-codecov-pipeline branch 11 times, most recently from 94269a5 to 1c7a168 Compare May 15, 2023 07:53
@reglim reglim changed the title Draft: Try to Fix the CodeCov Pipeline Fix the CodeCov Pipeline May 15, 2023
@reglim reglim force-pushed the fix/1164-fix-codecov-pipeline branch 2 times, most recently from 4fba69b to c7c5bdb Compare May 15, 2023 09:16
Copy link
Member

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reglim reglim force-pushed the fix/1164-fix-codecov-pipeline branch from c7c5bdb to 9d26498 Compare September 21, 2023 10:10
Update the ci to go version 20, fix go test coveroutput and add listener
that terminates the api in testing mode.
@reglim reglim force-pushed the fix/1164-fix-codecov-pipeline branch from 9d26498 to c49b588 Compare September 21, 2023 10:12
@aptly-dev aptly-dev deleted a comment from codecov bot Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1165 (c49b588) into master (f155ed3) will not change coverage.
The diff coverage is n/a.

❗ Current head c49b588 differs from pull request most recent head 5a2046d. Consider uploading reports for the commit 5a2046d to get more accurate results

@@           Coverage Diff           @@
##           master    #1165   +/-   ##
=======================================
  Coverage   65.96%   65.96%           
=======================================
  Files         143      143           
  Lines       16188    16188           
=======================================
  Hits        10679    10679           
  Misses       4756     4756           
  Partials      753      753           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@reglim reglim closed this Sep 21, 2023
@reglim reglim deleted the fix/1164-fix-codecov-pipeline branch September 21, 2023 10:27
@reglim reglim restored the fix/1164-fix-codecov-pipeline branch September 21, 2023 10:27
@reglim reglim reopened this Sep 21, 2023
@reglim reglim force-pushed the fix/1164-fix-codecov-pipeline branch 3 times, most recently from 4bc2b9e to 5405e77 Compare September 21, 2023 12:03
@reglim reglim force-pushed the fix/1164-fix-codecov-pipeline branch from 5405e77 to 5a2046d Compare September 21, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeCov does not recongize API Coverage properly
2 participants