Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:failed to edit repo #1093

Closed
wants to merge 1 commit into from

Conversation

cccccarl
Copy link

return when the repo cant be found and err !=nil

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

The repo cant be edited

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

return when  the repo cant be found and err !=nil
@randombenj randombenj self-requested a review July 25, 2022 12:52
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.31%. Comparing base (c9f5763) to head (0eafa62).
Report is 104 commits behind head on master.

Files Patch % Lines
api/repos.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1093       +/-   ##
===========================================
+ Coverage   52.11%   66.31%   +14.20%     
===========================================
  Files          73      141       +68     
  Lines       11272    15890     +4618     
===========================================
+ Hits         5874    10538     +4664     
+ Misses       4832     4603      -229     
- Partials      566      749      +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randombenj
Copy link
Member

I don't quite get what's the problem here, I would expect that when the repo already exists with the same name that it is not renamed and this is exactly how it is implementad at the moment.
This is also the same behaviour as in the cli: https://github.com/aptly-dev/aptly/blob/master/cmd/repo_rename.go#L30

@neolynx neolynx requested review from neolynx and removed request for randombenj April 11, 2024 19:29
@neolynx neolynx self-assigned this Apr 11, 2024
@neolynx neolynx mentioned this pull request Apr 20, 2024
6 tasks
@neolynx neolynx removed their request for review April 20, 2024 22:28
@neolynx neolynx closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants