-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve marshmallow deprecation warning and support marshmallow 4.0 #117
base: master
Are you sure you want to change the base?
Conversation
0e4606c
to
1790d39
Compare
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 98.44% 98.29% -0.15%
==========================================
Files 7 7
Lines 1285 1291 +6
==========================================
+ Hits 1265 1269 +4
- Misses 20 22 +2
Continue to review full report at Codecov.
|
I am not sure how to handle the test coverage decrease. Proper testing could involve running multiple tox environments and merging the coverage reports. |
Alternatively, marshmallow could be pinned to <4.0 for now. |
@kreathon The issue looks to be here: if marshmallow_version >= (3, 13, 0):
_ma_key_for_fr_example_key = "dump_default"
_ma_key_for_fr_default_key = "load_default"
else:
_ma_key_for_fr_example_key = "default"
_ma_key_for_fr_default_key = "missing" where the lines after the _ma_key_for_fr_example_key = "dump_default"
_ma_key_for_fr_default_key = "load_default"
if marshmallow_version < (3, 13, 0):
_ma_key_for_fr_example_key = "default"
_ma_key_for_fr_default_key = "missing" I would be interested to know if this works? @apryor6 can you provide any additional feedback? |
@circulon, you can check the But my fear is that this project is dead (and it is not about coverage) |
Bugger ;( @kreathon are you working with or know of any other projects that are active and provide similar functionality? Cheers |
@circulon I don't know. Personally, I am now sticking to plain Marshmallow. |
Proposal for #116.