Add a translatable=false attribute to apptentive_distribution strings #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitting this attributed causes Android Lint to flag these lines with the `MissingTranslation` issue. Since these strings don't appear to be intended to be translated (they just refer to a feature name/version), adding this attribute seems appropriate.
|
Hi @ddenisen! Thanks for the submission. I'll make sure my engineering team is aware for next steps. Please let me know if this is blocking you from a release, or if this is more of a 'nice to have'. Appreciate your feedback. |
|
Not blocking as I can filter this error out. Just something would be nice to fix to make things more convenient for devs who use this sdk. |
|
@ddenisen: perfect. Thanks for the context. |
frankus
force-pushed
the
develop
branch
2 times, most recently
from
a600052
to
7615d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting this attributed causes Android Lint to flag these lines with the
MissingTranslationissue. Since these strings don't appear to be intended to be translated (they just refer to a feature name/version), adding this attribute seems appropriate.Discovered when I expanded our project Lint coverage to include React Native dependency libraries.