New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the issue when nesting apptainer instance start
inside a container on cgroups-v2 capable host
#2220
Conversation
c620ebb
to
cfb1a83
Compare
it looks like we are building apptainer against el7 glibc for the |
Rebase on the current main branch to fix the rocky9 issue. The check_source issue found a typo you need to fix. |
I'm not sure what you mean. By default install-unprivileged.sh will install el7-built rpms no matter the host OS. When building rpms, it uses the host's glibc. |
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
cfb1a83
to
4dbcc1f
Compare
Yeah, that's what I plan to do, I would like to build the el7-built rpm to test the newly added code. Are we using docker to build such rpm? (I see some scripts in |
Yes, using docker. If you're not on an el7 host you can do what ci.yml does. |
@JasonYangShadow are you ready for this to merge or did you want to do more testing? |
yeah. I am okay with this PR. |
Please cherry-pick to the release-1.3 branch |
Description of the Pull Request (PR):
Unset
DBUS_SESSION_BUS_ADDRESS
whensystemd
is not available.This fixes or addresses the following GitHub issues:
apptainer instance start
fails inside of container on cgroups-v2 capable host #2164Before submitting a PR, make sure you have done the following:
make check
and tested this PR locally with amake test
, andmake testall
if possible (see CONTRIBUTING.md).