Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue when nesting apptainer instance start inside a container on cgroups-v2 capable host #2220

Merged
merged 2 commits into from May 14, 2024
Merged

Fixed the issue when nesting apptainer instance start inside a container on cgroups-v2 capable host #2220

merged 2 commits into from May 14, 2024

Conversation

JasonYangShadow
Copy link
Member

Description of the Pull Request (PR):

Unset DBUS_SESSION_BUS_ADDRESS when systemd is not available.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

@JasonYangShadow JasonYangShadow force-pushed the issue/2164 branch 2 times, most recently from c620ebb to cfb1a83 Compare May 10, 2024 05:39
@JasonYangShadow
Copy link
Member Author

it looks like we are building apptainer against el7 glibc for the install-unprivileged.sh, where are the steps for building such rpm?
besides, it looks like go mod tidy will upgrade the golang toolchain to go1.21.

@DrDaveD
Copy link
Contributor

DrDaveD commented May 10, 2024

Rebase on the current main branch to fix the rocky9 issue. The check_source issue found a typo you need to fix.

DrDaveD
DrDaveD requested changes May 10, 2024
View reviewed changes
internal/pkg/cgroups/manager_linux.go Outdated Show resolved Hide resolved
@DrDaveD
Copy link
Contributor

DrDaveD commented May 10, 2024

it looks like we are building apptainer against el7 glibc for the install-unprivileged.sh, where are the steps for building such rpm?

I'm not sure what you mean. By default install-unprivileged.sh will install el7-built rpms no matter the host OS. When building rpms, it uses the host's glibc.

@JasonYangShadow
fix nesting containers issue
fc9e1f2 
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
@JasonYangShadow
address comments
4dbcc1f 
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
@JasonYangShadow
Copy link
Member Author

it looks like we are building apptainer against el7 glibc for the install-unprivileged.sh, where are the steps for building such rpm?

I'm not sure what you mean. By default install-unprivileged.sh will install el7-built rpms no matter the host OS. When building rpms, it uses the host's glibc.

Yeah, that's what I plan to do, I would like to build the el7-built rpm to test the newly added code. Are we using docker to build such rpm? (I see some scripts in ci-docker-run, as referred in ci.yml)

@DrDaveD
Copy link
Contributor

DrDaveD commented May 13, 2024

I would like to build the el7-built rpm to test the newly added code. Are we using docker to build such rpm? (I see some scripts in ci-docker-run, as referred in ci.yml)

Yes, using docker. If you're not on an el7 host you can do what ci.yml does.

@DrDaveD
Copy link
Contributor

DrDaveD commented May 13, 2024

@JasonYangShadow are you ready for this to merge or did you want to do more testing?

@JasonYangShadow
Copy link
Member Author

@JasonYangShadow are you ready for this to merge or did you want to do more testing?

yeah. I am okay with this PR.

@DrDaveD DrDaveD merged commit ba2b4e1 into apptainer:main May 14, 2024
17 checks passed
@DrDaveD DrDaveD added this to the 1.3.2 milestone May 14, 2024
@DrDaveD
Copy link
Contributor

DrDaveD commented May 14, 2024

Please cherry-pick to the release-1.3 branch

@JasonYangShadow JasonYangShadow mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrDaveD DrDaveD DrDaveD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.

Nesting apptainer instance start fails inside of container on cgroups-v2 capable host
2 participants
@JasonYangShadow @DrDaveD