Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sun position algorithm #2870

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mororo250
Copy link
Contributor

Draft of sun position implementation.

Copy link
Member

@dictoon dictoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very partial and superficial first review!

src/appleseed/renderer/modeling/light/sunlight.cpp Outdated Show resolved Hide resolved
src/appleseed.python/module.cpp Outdated Show resolved Hide resolved
sandbox/settings/appleseed.studio.xml Outdated Show resolved Hide resolved
src/appleseed/renderer/modeling/scene/scene.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/utility/solarpositionalgorithm.h Outdated Show resolved Hide resolved
src/appleseed/renderer/utility/solarpositionalgorithm.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/utility/solarpositionalgorithm.cpp Outdated Show resolved Hide resolved
@mororo250 mororo250 marked this pull request as ready for review June 30, 2020 16:05
@dictoon
Copy link
Member

dictoon commented Jan 30, 2021

Hi,

@LZaw and I had another look at this PR. We feel that a few things need to be done in order for it to be merged.

In particular, the SunPositioner class presents itself as an appleseed entity (i.e. it inherits from renderer::Entity, etc.) but it doesn't really make sense.

Here is what we suggest:

  1. Don't make SunPositioner inherit from Entity
  2. Don't tag the class with APPLESEED_DLLSYMBOL
  3. Remove the constructor, pass arguments natively
  4. Remove the release() method
  5. Remove the private implementation
  6. Remove SunPositionerFactory

Essentially turns the class into a very plain C++ one, and expose it to Python like you're doing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants